Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default rustfmt version to supplied rust version #2660

Merged
merged 3 commits into from
May 17, 2024

Conversation

mattem
Copy link
Contributor

@mattem mattem commented May 17, 2024

Modifies the default of rustfmt_version so that it uses the first version in the versions list. If there are multiple versions given then falls back to the original default of DEFAULT_NIGHTLY_VERSION.

We tripped over this where supply a single Rust version (non-nightly), but started using nightly features in rustfmt.toml and could no longer format directly with cargo fmt. This helped align the versions of both toolchains.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion added this pull request to the merge queue May 17, 2024
Merged via the queue into bazelbuild:main with commit df80ce6 May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants