Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for cpp calling rust by including header #2174

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

daivinhtran
Copy link
Contributor

@daivinhtran daivinhtran commented Sep 28, 2023

This PR adds an example of cpp calling rust by using cc_import rule to include the header files and include paths.

@daivinhtran daivinhtran changed the title Add examples for cpp calling rust by including header Add example for cpp calling rust by including header Sep 28, 2023
@daivinhtran daivinhtran marked this pull request as ready for review September 28, 2023 18:00
@daivinhtran daivinhtran force-pushed the cc-call-rust-with-header branch 2 times, most recently from c25c102 to 516cb91 Compare September 28, 2023 19:13
@daivinhtran daivinhtran marked this pull request as draft September 28, 2023 19:22
@daivinhtran daivinhtran marked this pull request as ready for review September 29, 2023 14:47
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a README.md to examples/ffi/cpp_calling_rust_with_header to explain what's going on with words? I opened #1839 a while ago and would like to at some point refactor the examples to be demonstrating how to do common things vs treating them as integration tests like we do now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants