Outside of examples, fill in all edition
attrs
#1257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from #1256 in case these changes are easier to review separately.
This is effectively a fully exhaustive version of #1254. Due to #1251, specifying
edition
in each target is required in order for downstream workspaces importingrules_rust
to get a usable edition for all ofrules_rust
's targets, instead of attempting to use the downstream workspace's default edition which won't necessarily be appropriate.Note that under
examples
, I have addededition
to therust_register_toolchains
in various WORKSPACE.bazel files rather than to each individual target. This reduces noise in the example projects. I have not done the same for the top-level WORKSPACE because doing so would mask trouble along the lines of #1254.