Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for es2015 entry point field in rollup #429

Merged
merged 1 commit into from Feb 12, 2019

Conversation

gregmagolan
Copy link
Collaborator

Update to a version of rollup-plugin-node-resolve that supports es2015 entry points with fallback to module and main: https://github.com/gregmagolan/rollup-plugin-node-resolve/commit/7a33dc249b69497aff3380a37a359158167b4801.

Will put a PR up for rollup-plugin-node-resolve to land this in their repo.

Needed when rolling up rxjs here: angular/angular#27220

@gregmagolan
Copy link
Collaborator Author

/cc @alexeagle

@mgechev
Copy link
Collaborator

mgechev commented Nov 26, 2018

@gregmagolan @alexeagle is out of office for the next a couple of days. I can review the PR. I'll ping you on Slack to get a better context.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have WIP on here, I assume you don't want to merge this until you get a PR merged to the upstream? Probably a wise idea to make sure the next release of rollup-plugin-node-resolve will have what we need

@gregmagolan
Copy link
Collaborator Author

@alexeagle Yes. Will have some time tomorrow morning to make a PR to the node resolve plugin

@gregmagolan
Copy link
Collaborator Author

PR submitted to rollup-plugun-node-resolve: rollup/rollup-plugin-node-resolve#186

@gregmagolan
Copy link
Collaborator Author

Looks like this change in rollup-plugin-node-resolve was already in the works which will allow for handling es2015: rollup/rollup-plugin-node-resolve#182. Will land soon hopefully.

@gregmagolan gregmagolan changed the title [WIP] Add support for es2015 entry point field in rollup WIP: Add support for es2015 entry point field in rollup Dec 5, 2018
@gregmagolan gregmagolan changed the title WIP: Add support for es2015 entry point field in rollup Add support for es2015 entry point field in rollup Feb 12, 2019
@gregmagolan
Copy link
Collaborator Author

gregmagolan commented Feb 12, 2019

rollup/rollup-plugin-node-resolve#186 has still not landed. I made a custom dist based on rollup/rollup-plugin-node-resolve#186 which has been rebased to 4.0.0. Will go with that.

After #186 lands and makes it into the next rollup release we can update to that version. Its all behind the scenes so it shouldn't break anyone.

@alexeagle alexeagle merged commit f125e99 into bazelbuild:master Feb 12, 2019
alexeagle added a commit to alexeagle/rules_nodejs that referenced this pull request Oct 17, 2020
These already moved to rules_nodejs

Closes bazelbuild#429

PiperOrigin-RevId: 241422158
alexeagle added a commit to alexeagle/rules_nodejs that referenced this pull request Oct 18, 2020
These already moved to rules_nodejs

Closes bazelbuild#429

PiperOrigin-RevId: 241422158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants