feat: enable test file crawling for jest example #1506
Conversation
mrmeku
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
mrmeku
force-pushed
the
jest-node-modules
branch
from
76dac9b
to
071c26f
Compare
mrmeku
force-pushed
the
jest-node-modules
branch
from
071c26f
to
64076eb
Compare
| @@ -1,4 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
do you mean to check in this change?
There was a problem hiding this comment.
Maybe it shouldn't be part of this change, but in general I have to do this to rules_nodejs everytime I try to edit the repo in vscode. It breaks the bazel vscode extensions ability to format build files
|
|
||
| function findNative(roots, extensions, ignore, callback) { | ||
| const args = Array.from(roots); | ||
| + args.push('('); |
There was a problem hiding this comment.
is there an issue or PR open on the upstream repo so there's a chance of unwinding this patch later?
if so add a comment somewhere pointing to it, so we'll know when it's time to unpatch
There was a problem hiding this comment.
For my own reference, he's the PR I've started with Jest: jestjs/jest#9351
| @@ -10,8 +10,6 @@ def jest_test(name, srcs, deps, jest_config, **kwargs): | |||
| "--ci", | |||
| ] | |||
| args.extend(["--config", "$(location %s)" % jest_config]) | |||
There was a problem hiding this comment.
I was expecting to see a glob pattern being added here or in the place jest_test is called
There was a problem hiding this comment.
The glob pattern was already present within jest.config.js (that's the idiomatic way of specifying tests to jest). Do you have a different API you would prefer?
| + args.push('('); | ||
| args.push('-type', 'f'); | ||
| + args.push('-o'); | ||
| + args.push('-type', 'l'); |
There was a problem hiding this comment.
I don't quite understand where the symlinks are appearing. The node-patches should make it so the source files appear to be in the runfiles tree, not symlinks out of the runfiles. Are you sure the fix belongs in jest and not in the node-patches? Can you show where the symlink appears and where it points?
There was a problem hiding this comment.
The symlinks appear within the runfiles tree of the testable target. nodejs_binary creates a runfiles directory which is filled with symlinks to the original files.
|
In a followup could you add something to the examples/jest README so users understand they also have to copy and apply the patch if they want their globs to work? |
PR Checklist
Before, the jest example macro used the
runTestsByPathcommand line flag to specify test locations. Now, using a small patch to jest to enable symlinks, the more iodmatic method of using a test match glob pattern is used.testMatch: ['**/*.test.js']