Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate linting #529

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Commits on Apr 14, 2021

  1. Separate loading repositories from things that might use those downloads

    The `kotlin_repositories` macro is designed to download the third
    party dependencies that rules_kotlin has for itself. Because of the
    way that Bazel works, these must first be downloaded before they can
    be referred to by build files.
    shs96c committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    ea74122 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Automatically generate lint tests if required

    If a user has chosen to enable linting, `rules_kotlin` will now
    generate ktlint tests automatically. These can be run with a `bazel
    test --test_tag_filters=lint //...`
    shs96c committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    fc3872a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Work around stardoc limitations to generate docs

    Stardoc doesn't allow a macro to wrap a rule and also have the rule's
    documentation be generated.
    
    Ideally, we'd simply exclude the lint wrappers and omit the `input`
    attribute from the `stardoc` target. However, thanks to [an issue with
    stardoc](bazelbuild/stardoc#99) this is not
    an option. As an alternative, we provide a verion of `rules.bzl` that
    deliberately excludes the lint wrappers.
    shs96c committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    8eec34e View commit details
    Browse the repository at this point in the history