Add support for --incompatible_enable_proto_toolchain_resolution
#3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexeagle None of us have worked with proto toolchains so far, so it would be great if you could also take a look. |
fmeum
force-pushed
the
3895-proto
branch
7 times, most recently
from
57bee2d
to
69df93d
Compare
|
FYI @sluongng You might find this interesting :-) |
sluongng
reviewed
Apr 12, 2024
|
I'll take another stab at fixing the integration tests next week. Everything else is stable for review. |
|
I updated rules_proto to 6.0.0 and fixed the remaining tests, PTAL @linzhp @tyler-french |
linzhp
approved these changes
May 12, 2024
|
@sluongng FYI looks like this PR will merge as soon as you click "Resolve" on the two open threads; are they answered to your satisfaction? |
|
Hmm i cannot resolve the conversations. Perhaps @fmeum can. The PR LGTM. I hope the legacy toolchain still provide an alternative option to use protoc from source. Cheers! |
tyler-french
added a commit
that referenced
this pull request
May 21, 2024
This PR prepares a minor release to allow downstream users to begin integrating with #3919
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
May 22, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.47.1` -> `v0.48.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.48.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.48.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.47.1...v0.48.0) #### Important Changes! `--incompatible_enable_proto_toolchain_resolution` is now supported in `rules_go`. This means that protoc should now be supplied as a toolchain. `protoc` can be registered using https://github.com/aspect-build/toolchains_protoc, or a local proto toolchain can be added. #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "33acc4ae0f70502db4b893c9fc1dd7a9bf998c23e7ff2c4517741d4049a976f8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.3") #### What's Changed - Update docs to cover new FilePath ReplaceDirective Support by [@​stefanpenner](https://togithub.com/stefanpenner) in [bazelbuild/rules_go#3931 - go_test: use different mnemonic for compilation by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3936 - Add go.work support to the documentation by [@​stefanpenner](https://togithub.com/stefanpenner) in [bazelbuild/rules_go#3932 - feat(mode): add `purego` tag when `pure` by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [bazelbuild/rules_go#3901 - generate_test_main: Move timeout handling back to bzltestutil by [@​DolceTriade](https://togithub.com/DolceTriade) in [bazelbuild/rules_go#3939 - Add support for `--incompatible_enable_proto_toolchain_resolution` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3919 - Add exec_compatible_with to @​go_sdk//:builder by [@​EdSchouten](https://togithub.com/EdSchouten) in [bazelbuild/rules_go#3943 - prepare v0.48.0 release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3946 #### New Contributors - [@​stefanpenner](https://togithub.com/stefanpenner) made their first contribution in [bazelbuild/rules_go#3931 **Full Changelog**: bazelbuild/rules_go@v0.47.1...v0.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
May 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.47.1` -> `v0.48.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.48.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.48.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.47.1...v0.48.0) #### Important Changes! `--incompatible_enable_proto_toolchain_resolution` is now supported in `rules_go`. This means that protoc should now be supplied as a toolchain. `protoc` can be registered using https://github.com/aspect-build/toolchains_protoc, or a local proto toolchain can be added. #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "33acc4ae0f70502db4b893c9fc1dd7a9bf998c23e7ff2c4517741d4049a976f8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.3") #### What's Changed - Update docs to cover new FilePath ReplaceDirective Support by [@​stefanpenner](https://togithub.com/stefanpenner) in [bazelbuild/rules_go#3931 - go_test: use different mnemonic for compilation by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3936 - Add go.work support to the documentation by [@​stefanpenner](https://togithub.com/stefanpenner) in [bazelbuild/rules_go#3932 - feat(mode): add `purego` tag when `pure` by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [bazelbuild/rules_go#3901 - generate_test_main: Move timeout handling back to bzltestutil by [@​DolceTriade](https://togithub.com/DolceTriade) in [bazelbuild/rules_go#3939 - Add support for `--incompatible_enable_proto_toolchain_resolution` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3919 - Add exec_compatible_with to @​go_sdk//:builder by [@​EdSchouten](https://togithub.com/EdSchouten) in [bazelbuild/rules_go#3943 - prepare v0.48.0 release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3946 #### New Contributors - [@​stefanpenner](https://togithub.com/stefanpenner) made their first contribution in [bazelbuild/rules_go#3931 **Full Changelog**: bazelbuild/rules_go@v0.47.1...v0.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->
](https://renovatebot.com){kind=link}
fmeum
pushed a commit
to bazel-contrib/toolchains_llvm
that referenced
this pull request
May 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.47.1` -> `v0.48.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.48.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.48.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.47.1...v0.48.0) #### Important Changes! `--incompatible_enable_proto_toolchain_resolution` is now supported in `rules_go`. This means that protoc should now be supplied as a toolchain. `protoc` can be registered using https://github.com/aspect-build/toolchains_protoc, or a local proto toolchain can be added. #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "33acc4ae0f70502db4b893c9fc1dd7a9bf998c23e7ff2c4517741d4049a976f8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.3") #### What's Changed - Update docs to cover new FilePath ReplaceDirective Support by [@​stefanpenner](https://togithub.com/stefanpenner) in [bazelbuild/rules_go#3931 - go_test: use different mnemonic for compilation by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3936 - Add go.work support to the documentation by [@​stefanpenner](https://togithub.com/stefanpenner) in [bazelbuild/rules_go#3932 - feat(mode): add `purego` tag when `pure` by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [bazelbuild/rules_go#3901 - generate_test_main: Move timeout handling back to bzltestutil by [@​DolceTriade](https://togithub.com/DolceTriade) in [bazelbuild/rules_go#3939 - Add support for `--incompatible_enable_proto_toolchain_resolution` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3919 - Add exec_compatible_with to @​go_sdk//:builder by [@​EdSchouten](https://togithub.com/EdSchouten) in [bazelbuild/rules_go#3943 - prepare v0.48.0 release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3946 #### New Contributors - [@​stefanpenner](https://togithub.com/stefanpenner) made their first contribution in [bazelbuild/rules_go#3931 **Full Changelog**: bazelbuild/rules_go@v0.47.1...v0.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
With
--incompatible_enable_proto_toolchain_resolution, users ofprotocare expected to obtain it through@rules_proto//proto:toolchain_typeinstead of the Bazel command line flag--proto_compiler. This change adds support for this in a backwards compatible way.Note that the above is actually a lie: The proper way to use
protocwould be to go through a Go-specificproto_lang_toolchainand use the methods onproto_commonto interact withprotoc. Since rules_go has a very bespoke setup with customizable compilers and the need to apply reset transitions in caseprotocis built from source, this would require major changes. We should revisit this after Proto toolchainization has been enabled by default.Which issues(s) does this PR fix?
Fixes #3895
Other notes for review