Add support for path mapping #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
supports-path-mapping
branch
from
efb2380
to
08d2e4a
Compare
|
@linzhp @tyler-french Would be interested in hearing your thoughts on this, let me know if you want more context. |
linzhp
reviewed
Apr 10, 2024
linzhp
reviewed
Apr 11, 2024
fmeum
force-pushed
the
supports-path-mapping
branch
from
08d2e4a
to
323955a
Compare
|
I fixed the merge conflict and added comments to explain why these slightly more convoluted |
linzhp
approved these changes
May 11, 2024
fmeum
force-pushed
the
supports-path-mapping
branch
from
323955a
to
c84a30e
Compare
fmeum
force-pushed
the
supports-path-mapping
branch
from
c84a30e
to
808c3bf
Compare
Path mapping improves disk/remote cache hit ratio by automatically removing the configuration-specific path segments (e.g. `k8-fastbuild-ST-12345678`) from action command lines before staging them for execution. This commit makes the stdlib, compilepkg (assuming no cgo) and gentestmain actions compatible with path mapping, which is mostly automatic except that `GOROOT` now needs to be passed in via a flag rather than an environment variable. Can be tested via `--experimental_output_paths=strip` with Bazel last_green. See https://www.youtube.com/watch?v=Et1rjb7ixUU for more information on path mapping.
fmeum
force-pushed
the
supports-path-mapping
branch
from
808c3bf
to
3d12a56
Compare
|
I removed the workaround for the Bazel bug that has now been fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Path mapping improves disk/remote cache hit ratio by automatically removing the configuration-specific path segments (e.g.
k8-fastbuild-ST-12345678) from action command lines before staging them for execution.This commit makes the stdlib, compilepkg (assuming no cgo) and gentestmain actions compatible with path mapping, which is mostly automatic except that
GOROOTnow needs to be passed in via a flag rather than an environment variable.See https://www.youtube.com/watch?v=Et1rjb7ixUU for more information on path mapping.
Which issues(s) does this PR fix?
Other notes for review
Can be tested via
--experimental_output_paths=stripwith Bazel last_green.