Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2.0] Make rules_android mobile-install v3 compatible with Bazel 7.2.0 #22324

Merged
merged 2 commits into from May 10, 2024

Conversation

ted-xie
Copy link
Contributor

@ted-xie ted-xie commented May 10, 2024

No description provided.

ajsinclair and others added 2 commits May 10, 2024 14:55
We call DexMerger via SpawnActionTemplate which is only available in native Blaze. So we must expose the parameter to the Starlark API.

PiperOrigin-RevId: 604482423
Change-Id: I2c9c165373d35cb1f7a6f928c11839b201973bed
PiperOrigin-RevId: 596676516
Change-Id: I0c60aa371c9ee99d27e47e5b75480e881b5e9da2
@ted-xie ted-xie marked this pull request as ready for review May 10, 2024 19:29
@ted-xie ted-xie requested a review from a team as a code owner May 10, 2024 19:29
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Android Issues for Android team labels May 10, 2024
@ted-xie
Copy link
Contributor Author

ted-xie commented May 10, 2024

Verified that a basic bazel build and bazel mobile-install works with latest rules_android with these cherry-picks.

@keertk keertk self-requested a review May 10, 2024 19:35
@keertk keertk added this pull request to the merge queue May 10, 2024
@keertk keertk added this to the 7.2.0 release blockers milestone May 10, 2024
@keertk keertk changed the title Make rules_android mobile-install v3 compatible with Bazel 7.2.0 [7.2.0] Make rules_android mobile-install v3 compatible with Bazel 7.2.0 May 10, 2024
Merged via the queue into bazelbuild:release-7.2.0 with commit 1d5fdaf May 10, 2024
34 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants