[7.2.0] Combined cc_shared_library cherry-picks #22321
Merged
+185
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the functionality to generate .pdb files when building a DLL from a cc_shared_library target with the Lexan toolchain, which is already supported when using a cc_binary target. The change has been tested manually with a local cc_shared_library target, with and without the shared_lib_name attribute. I'm not exactly sure how the automated/unit tests for cc_shared_library work, but it seems like when the test targets in //third_party/bazel/src/main/starlark/tests/builtins_bzl/cc/cc_shared_library/test_cc_shared_library/BUILD.builtin_test are built for Windows, the pdb logic should also be executed, so if there are failures they should be caught. A test that would make sense is to check the filenames for the generated pdb files, but I don't see tests that do this for DLLs so I assume we're not doing that for Windows. PiperOrigin-RevId: 588441321 Change-Id: I20aa6d855514d3864c7f2f4b658f279367128030
…uilds. This will decrease binary size for binaries built with fastbuild by ~15-17% (https://docs.google.com/spreadsheets/d/1Jy-jvrdfp3hcf5-EIAUj5Arr6-6g9y0A14sdTGZiqMM/edit?resourcekey=0-9qG_DHCYO0N-3TrRsGoYZA#gid=899160323) BEGIN_PUBLIC Increase memory for link actions. END_PUBLIC PiperOrigin-RevId: 601570607 Change-Id: I54614de97ca8affb73fb2eece38d6671bfe6e83a
Simplifies the test of `cc_shared_library`'s runfiles behavior using new rules_testing features, which also result in better failure messages. Also format `BUILD.builtin_test` with buildifier to simplify future contributions. Work towards bazelbuild#21833 Closes bazelbuild#21880. PiperOrigin-RevId: 626315579 Change-Id: Ib7b3d1367586ba7215132d6a9f3711f4ae0a9b09
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This matches `cc_binary`'s behavior at https://github.com/bazelbuild/bazel/blob/d738910e83427d394526cbdfc8ac665027dd9196/src/main/starlark/builtins_bzl/common/cc/cc_binary.bzl#L828-L832 Fixes bazelbuild#21602 Closes bazelbuild#21900. PiperOrigin-RevId: 626309605 Change-Id: I58683eaa2eedd590746e51df8c97833527c409f4
Work towards bazelbuild#21622 RELNOTES: `native.package_relative_label` can now be used in rule initializers. Closes bazelbuild#21740. PiperOrigin-RevId: 631546734 Change-Id: Id6eb237f0f79195b678bb954deaef071e1c45ab1
github-actions
bot
added
awaiting-review
|
Thanks! Looks like 22283 is waiting on some internal fixes. |
keertk
changed the title
Wyverald
approved these changes
May 10, 2024
Merged
via the queue into
bazelbuild:release-7.2.0
with commit May 10, 2024
cfb9491
33 checks passed
github-actions
bot
removed
the
awaiting-review
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks:
Closes #21986
Closes #22053
Closes #22113