Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel_ci_rules@1.0.0 #2058

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 18, 2024

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (bazel_ci_rules) have been updated in this PR. Please review the changes.

@fmeum
Copy link
Contributor

fmeum commented May 19, 2024

Let's wait for the Bazel team to say whether they want this to be a module or not (and in which form).

@Wyverald

@mmorel-35
Copy link
Contributor Author

There is already one on the master branch, this add it for the 1.0.0 tag, see https://github.com/bazelbuild/continuous-integration/blob/master/rules/MODULE.bazel

@bazel-io
Copy link
Member

bazel-io commented Jun 3, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (bazel_ci_rules) have been updated in this PR. Please review the changes.

@mmorel-35
Copy link
Contributor Author

@meteorcloudy ,
What do you think about this ?

@meteorcloudy
Copy link
Member

meteorcloudy commented Jun 3, 2024

@coeuvre Do we need the bazel ci rules to be a BCR module? How is it used currently?

@meteorcloudy
Copy link
Member

https://github.com/bazelbuild/rules_rust/blob/dc08bde7a83d882539a08cffa844854d564204b8/examples/crate_universe/WORKSPACE.bazel#L731-L739

Looks like it ships a repo rule, so it probably makes sense for it to be a BCR module.

@mmorel-35
Copy link
Contributor Author

Can someone provide the appropriate label to proceed?

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jun 3, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this one since it makes the remote execution setup easier for Bazel CI users.

@meteorcloudy meteorcloudy merged commit 9d0bf47 into bazelbuild:main Jun 3, 2024
18 checks passed
@mmorel-35 mmorel-35 deleted the bazel_ci_rules@1.0.0 branch June 3, 2024 16:03
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this pull request Jun 6, 2024
bazel_ci_rules@1.0.0 module has been published to the BCR, see bazelbuild/bazel-central-registry#2058

This use it has a bazel_dep instead of a http_archive

Closes #22618.

PiperOrigin-RevId: 640818741
Change-Id: Ic54471730b371c88e985fe3923646cd880dbe1d2
github-merge-queue bot pushed a commit to bazelbuild/rules_rust that referenced this pull request Jun 6, 2024
bazel_ci_rules@1.0.0 module has been published to the BCR, see
bazelbuild/bazel-central-registry#2058

This use it has a bazel_dep instead of a http_archive

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants