Add pybind11_abseil

[mering]

No description provided.

[bazel-io]

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (pybind11_abseil) have been updated in this PR. Please review the changes.

[fmeum]

@rwgk @junyer Would you be willing to maintain this BCR entry and are you okay with its contents?

[mering]

As discussed internally, I propse @frigus02 as maintainer. Are you willing to accept?

[mering]

@fmeum could you please trigger the tests?

[frigus02]

I accept

[mering]

@fmeum could you please trigger the tests?

[mering]

Anyone has an idea why the tests can't find @python or @pypi even though they are defined within MODULE.bazel?

[fmeum]

It's because of dev_dependency = True. The module is tested from an anonymous root module, so it won't be the root module itself.

[mering]

@fmeum Would there be any problems with just removing this?

[mering]

@fmeum Hmm. Even after removing the dev_dependency it still seems to fail with the same error.

[fmeum]

It's still failing, but for a different reason. You may just need to pass in --cxxopt=-std=c++14.

[mering]

@fmeum Thanks. Linux builds seem to run fine with --cxxopt=-std=c++14 but Windows and MacOS builds fail now. I don't have any such architecture available to test.

Windows tests now fail with

cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
C:\b\ehbqvbze\execroot\_main\external\pybind11_abseil~202402.0\pybind11_abseil/compat/py_base_utilities.h(9): error C2429: language feature 'nested-namespace-definition' requires compiler flag '/std:c++17'
external/pybind11_abseil~202402.0/pybind11_abseil/compat/py_base_utilities.cc(12): error C2429: language feature 'nested-namespace-definition' requires compiler flag '/std:c++17'

What is the best way to set a minimum C++ version across all supported OSes?

[junyer]

If it helps, RE2 does this.

[mering]

@junyer IIUC .bazelrc is not taken into account from BCR tests as the module under test is added as dependency. What is the best way to specify different flags per architecture in presubmit.yml in BCR?

[mering]

MacOS fails with

ld: symbol(s) not found for architecture x86_64

Any idea what could be wrong here?

[mering]

Windows now fails with

external/pybind11_abseil~202402.0/pybind11_abseil/tests/cpp_capsule_tools_testing.cc(24): error C2466: cannot allocate an array of constant size 0

[junyer]

https://buildkite.com/bazel/bcr-presubmit/builds/5056#018f2f66-e390-4cb3-9159-7c13bd0741d0 indicates otherwise:

…
(14:27:18) INFO: Reading rc options for 'test' from c:\b\bk-windows-60p1\bazel-org-repo-root\output\re2-2024-05-01\.bazelrc:
  Inherited 'build' options: --features=layering_check --features=parse_headers --enable_platform_specific_config --experimental_enable_bzlmod --registry=file:///c:/b/bk-windows-60p1/bazel/bcr-presubmit
(14:27:18) INFO: Reading rc options for 'test' from c:\b\bk-windows-60p1\bazel-org-repo-root\output\re2-2024-05-01\.bazelrc:
  'test' options: --test_output=errors
(14:27:18) INFO: Found applicable config definition build:windows in file c:\b\bk-windows-60p1\bazel-org-repo-root\output\re2-2024-05-01\.bazelrc: --cxxopt=/std:c++14
…

[mering]

I removed tests for Windows and MacOS as upstream also doesn't test this: https://github.com/pybind/pybind11_abseil/blob/master/.github/workflows/actions.yml.

Tests are passing now.