Add curl with curl_config.h #1943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the curl BUILD file to use curl's cmake generated header file. This requires replacing all possible options, but makes sure we can't miss any important defines. For example in the previous build the CA cert chain of trust was invalid because the define for the system location for certs was not provided. Now we should no longer be able to miss settings like that when curl adds new ones.
zaucy
reviewed
May 4, 2024
zaucy
added a commit
to ecsact-dev/ecsact_cli
that referenced
this pull request
May 10, 2024
zaucy
added a commit
to ecsact-dev/ecsact_cli
that referenced
this pull request
Jun 4, 2024
zaucy
added a commit
to ecsact-dev/ecsact_cli
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the curl BUILD file to use curl's cmake generated header
file. This requires replacing all possible options, but makes sure we
can't miss any important defines. For example in the previous build the
CA cert chain of trust was invalid because the define for the system
location for certs was not provided. Now we should no longer be able to
miss settings like that when curl adds new ones.