Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor user authentication #113 #124

Merged
merged 16 commits into from
Mar 3, 2019

Conversation

famoser
Copy link
Member

@famoser famoser commented Mar 2, 2019

Will resolve #113

@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #124 into dev will decrease coverage by 1.39%.
The diff coverage is 14.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev     #124     +/-   ##
===========================================
- Coverage     62.26%   60.86%   -1.4%     
- Complexity     2440     2496     +56     
===========================================
  Files           305      312      +7     
  Lines          5999     6191    +192     
===========================================
+ Hits           3735     3768     +33     
- Misses         2264     2423    +159
Impacted Files Coverage Δ Complexity Δ
src/Security/DatabaseProvider.php 60% <ø> (ø) 6 <0> (?)
...Security/Authentication/Base/BaseAuthenticator.php 0% <0%> (ø) 1 <1> (?)
src/Form/ConstructionManager/CreateType.php 0% <0%> (ø) 1 <1> (?)
src/Form/Traits/User/CreateType.php 0% <0%> (ø) 1 <1> (?)
src/Controller/HelpController.php 0% <0%> (ø) 1 <1> (?)
src/Service/Ldap/LdapLogger.php 0% <0%> (ø) 5 <5> (?)
src/Controller/Base/BaseLoginController.php 41.93% <0%> (ø) 11 <0> (ø) ⬇️
src/DataFixtures/LoadConstructionManagerData.php 0% <0%> (ø) 3 <0> (ø) ⬇️
src/Form/ConstructionManager/ProfileType.php 0% <0%> (ø) 2 <2> (?)
src/Controller/LoginController.php 7.35% <0%> (-6.74%) 25 <18> (+14)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40965ff...751f2a9. Read the comment docs.

@famoser famoser merged commit 0457824 into dev Mar 3, 2019
@famoser famoser deleted the feature/refactor-user-authentication-113 branch March 3, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants