Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .gz file in man dir #753

Closed
wants to merge 1 commit into from
Closed

Use .gz file in man dir #753

wants to merge 1 commit into from

Conversation

ggvl
Copy link

@ggvl ggvl commented Jul 24, 2023

Normally, we use the .gz file as a manual.

@ggvl ggvl requested a review from a team as a code owner July 24, 2023 04:28
@ggvl ggvl force-pushed the master branch 2 times, most recently from 819ecac to 76b8ca0 Compare July 26, 2023 01:03
@martin-schulze-vireso
Copy link
Member

Do you plan on addressing the failed tests?

Signed-off-by: lvgenggeng <lvgenggeng@uniontech.com>
@ggvl
Copy link
Author

ggvl commented Aug 25, 2023

Do you plan on addressing the failed tests?

Yes, I will handle it.

@gioele
Copy link
Contributor

gioele commented Sep 27, 2023

This change breaks the Debian packaging a subtle way and I assume is not really needed.

RPM surely has a way (e.g. brp-compress) to automatically canonicalize and compress manpages installed into /usr/share/man, given that all automake-based programs install plain uncompressed man pages.

Installing compressed manpages is a responsibility/policy of the distributions and not something that the Makefile of upstream project (bats in this case) should be doing.

@martin-schulze-vireso
Copy link
Member

I am going to trust @gioele on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants