-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lacking documentation of setup_suite #652
Merged
martin-schulze-vireso
merged 11 commits into
bats-core:master
from
martin-schulze-vireso:fix/issue_635_lacking_documentation_of_setup_suite
Sep 14, 2022
Merged
Fix lacking documentation of setup_suite #652
martin-schulze-vireso
merged 11 commits into
bats-core:master
from
martin-schulze-vireso:fix/issue_635_lacking_documentation_of_setup_suite
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-schulze-vireso
force-pushed
the
fix/issue_635_lacking_documentation_of_setup_suite
branch
from
September 14, 2022 23:00
b51c6ad
to
78b283f
Compare
Hi, the Changelog entries talking about setup_file while the documentation is about setup_suite. Not sure, if this is intended. |
Thanks for the heads up. |
@jkroepke I pushed a fix to the changelog.md and fixed the changelog on the release page as well. Thanks again for the notification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635 , also adds BW03 to warn about this.