Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lacking documentation of setup_suite #652

Conversation

martin-schulze-vireso
Copy link
Member

Fixes #635 , also adds BW03 to warn about this.

@martin-schulze-vireso martin-schulze-vireso requested a review from a team as a code owner September 14, 2022 22:59
@martin-schulze-vireso martin-schulze-vireso force-pushed the fix/issue_635_lacking_documentation_of_setup_suite branch from b51c6ad to 78b283f Compare September 14, 2022 23:00
@martin-schulze-vireso martin-schulze-vireso merged commit 9734665 into bats-core:master Sep 14, 2022
@jkroepke
Copy link
Contributor

Hi, the Changelog entries talking about setup_file while the documentation is about setup_suite.

Not sure, if this is intended.

@martin-schulze-vireso
Copy link
Member Author

Thanks for the heads up.

@martin-schulze-vireso
Copy link
Member Author

@jkroepke I pushed a fix to the changelog.md and fixed the changelog on the release page as well. Thanks again for the notification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup_suite: exported variables are gone
2 participants