Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#81 json schema for json diagram config #96

Merged

Conversation

korzol
Copy link
Contributor

@korzol korzol commented Apr 8, 2020

Hello @ceckoslab
Here is an intermediate pull request, so you can check yourself the issue described on #81

@korzol korzol linked an issue Apr 9, 2020 that may be closed by this pull request
@korzol
Copy link
Contributor Author

korzol commented Apr 9, 2020

Hello @ceckoslab
Kindly review latest changes

Thank you!

@korzol korzol self-assigned this Apr 9, 2020
@ceckoslab
Copy link
Contributor

In all the screenshot you've shared in the ticket we observer that there are icons in the top left corner of the popup we have icons: #81 (comment)

When I run this PR locally I do not see the icons:
Basic RUM

Also in my network tab I see 404 for file: plugins/jsoneditor/img/jsoneditor-icons.svg

Reference:
Screenshot from 2020-04-10 15-54-46

@ceckoslab
Copy link
Contributor

Hello @korzol

As we discussed let's leave the hardcoded JSON but to leave just enough so it shows the structure of the JSON.

@korzol korzol changed the title WIP: Issue/#81 json schema for json diagram config WIPIssue/#81 json schema for json diagram config Apr 13, 2020
@korzol korzol changed the title WIPIssue/#81 json schema for json diagram config Issue/#81 json schema for json diagram config Apr 13, 2020
@ceckoslab ceckoslab merged commit fa15d1f into basicrum:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Schema for JSON diagram config
2 participants