Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of deprecated HTTP library for explainshell #564

Merged
merged 4 commits into from
Nov 26, 2022

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Nov 26, 2022

Closes #534

Note that this also closes the security warnings related to using the request library.

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #564 (9b93096) into main (a7fba71) will increase coverage by 0.44%.
The diff coverage is 28.57%.

❗ Current head 9b93096 differs from pull request most recent head 04f2d23. Consider uploading reports for the commit 04f2d23 to get more accurate results

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   74.41%   74.85%   +0.44%     
==========================================
  Files          19       19              
  Lines         680      676       -4     
  Branches      120      119       -1     
==========================================
  Hits          506      506              
+ Misses        158      154       -4     
  Partials       16       16              
Impacted Files Coverage Δ
server/src/server.ts 59.37% <0.00%> (+0.61%) ⬆️
server/src/analyser.ts 84.97% <11.11%> (+0.97%) ⬆️
server/src/util/shebang.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@skovhus skovhus merged commit ec8c828 into main Nov 26, 2022
@skovhus skovhus deleted the explain-shell-update branch November 26, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace request and request-promise-native with better http client
1 participant