Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace request and request-promise-native with better http client #534

Closed
lakshya-sky opened this issue Oct 27, 2022 · 1 comment · Fixed by #564
Closed

replace request and request-promise-native with better http client #534

lakshya-sky opened this issue Oct 27, 2022 · 1 comment · Fixed by #564
Labels
good first issue Good for newcomers

Comments

@lakshya-sky
Copy link

Both the packages have been deprecated and needs to be replaced with a better one. here is the alternative list.
request/request#3143

I think we should use undici as it is from node devs.

What are your opinions?

@lakshya-sky lakshya-sky closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2022
@skovhus
Copy link
Collaborator

skovhus commented Nov 15, 2022

Good point. As fetch is already shipped with experimental support in node 18, then I'm leaning towards node-fetch. If we need any special features then axios is a very solid choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants