Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSFIX] Major version upgrade of commander from version 8.1.0 to 9.4.0 #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsfix-ci
Copy link

@jsfix-ci jsfix-ci commented Sep 19, 2022

This pull request was created by barslev using the JSFIX tool (https://jsfix.live) by Coana.tech (https://coana.tech).
It upgrades commander to version 9.4.0.

The JSFIX tool used advanced program analysis to determine how commander is used by codeql-action and how it is affected by breaking changes in commander version 9.4.0 (see details below). JSFIX checked for the 3 breaking changes affecting commander version 9.4.0 and found 2 occurrences in codeql-action. 1 of the occurrences must be manually audited. 1 of the occurrences are unlikely to affect your code, but we recommend manually reviewing them (see details below).

Install the JSFIX GitHub app to receive other package upgrades from JSFIX.


Breaking change details

馃毀 - Not automatically fixed breaking changes (please check before merging)
Affects all applications (not related to specific API usages in your code).
  • Commander 9 requires Node.js v12.20.0 or higher
Unlikely breaking changes (Your code is probably not affected, but JSFIX is uncertain).
  • removed internal fallback to require.main.filename when script not known from arguments passed to .parse()
    • Hint for the match below: Only relevant if you depend on commander auto-generating a specific name for your application, which is typically only the case if you use standalone executable subcommands. In that case, you can always set the name manually using the .name method or specify the location of the executable subcommand using the .executableDir method. For a detailed explanation of this problem see the PR: Rework default program name, and searching for subcommands聽tj/commander.js#1571
Breaking changes where JSFIX found that there were no occurrences.

Visit https://jsfix.live/about-jsfix to learn more about how JSFIX works.

If you would like to provide feedback to the JSFIX developers, then please leave a comment on this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant