Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include go mod vendor to resolve licensei detection failures #907

Merged
merged 1 commit into from Mar 8, 2023

Conversation

nishantapatil3
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes random licensei check failures
License Apache 2.0

What's in this PR?

Include go mod vendor stage in github actions to avoid false-positive when modules github repo could not be determined

Why?

licensei check fails randomly sometimes when github repo license could not be determined

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@nishantapatil3
Copy link
Contributor Author

Source link where this solution was discussed: banzaicloud/koperator#853 (comment)

@sagikazarmark
Copy link
Member

Opened an issue to improve VCS detection: goph/licensei#44

@sagikazarmark
Copy link
Member

sagikazarmark commented Mar 8, 2023

@nishantapatil3 haven't used licensei for a while.

If you could open an issue/discussion with some feedback and the latest pain points and what kind of solution you would prefer, it would be helpful.

Thanks!

Copy link
Member

@Laci21 Laci21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nishantapatil3
Copy link
Contributor Author

Thanks for the approval @Laci21

@nishantapatil3 nishantapatil3 merged commit fa2250a into release-1.15 Mar 8, 2023
@nishantapatil3 nishantapatil3 deleted the mod_vendor branch March 8, 2023 16:47
@nishantapatil3
Copy link
Contributor Author

@nishantapatil3 haven't used licensei for a while.

If you could open an issue/discussion with some feedback and the latest pain points and what kind of solution you would prefer, it would be helpful.

Thanks!

Yes definitely @sagikazarmark! I'll put together few points that can improve licensei 🚀

@nishantapatil3 nishantapatil3 restored the mod_vendor branch March 8, 2023 16:57
nishantapatil3 added a commit that referenced this pull request Mar 9, 2023
Cherry-pick commit #907 to release-1.16
nishantapatil3 added a commit that referenced this pull request Mar 9, 2023
Cherry-pick commit #907 to release-1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants