Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize fingerprints on blake3 #12

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: normalize fingerprints on blake3 #12

merged 1 commit into from
Nov 21, 2023

Conversation

amiller68
Copy link
Contributor

No description provided.

@amiller68 amiller68 requested a review from a team as a code owner November 21, 2023 19:53
sstelfox
sstelfox approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@sstelfox sstelfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One outstanding question, but it doesn't require any changes. If sha2 isn't necessary I'd like to see it get pulled out here as well. If not, then not a big deal

Cargo.toml
hkdf = "^0.12"
blake3 = "^1.4"
sha2 = "^0.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need sha2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we're using for hkdf derivation

@amiller68 amiller68 merged commit cdd5e07 into main Nov 21, 2023
6 checks passed
@amiller68 amiller68 deleted the alex/blake3-fingerprint branch November 21, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstelfox sstelfox sstelfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amiller68 @sstelfox