Add react/function-component-definition #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doong-jo
commented
Apr 20, 2022
doong-jo
commented
- Add react/function-component-definition styleguide rule
- fix foramt
doong-jo
commented
Apr 20, 2022
| @@ -23,7 +23,7 @@ module.exports = { | |||
| "plugin:@typescript-eslint/recommended", | |||
| "plugin:import/typescript", | |||
| ], | |||
| plugins: ["react", "jsx-a11y", "import", "prettier", "@typescript-eslint", "simple-import-sort",], | |||
| plugins: ["react", "jsx-a11y", "import", "prettier", "@typescript-eslint", "simple-import-sort"], | |||
doong-jo
commented
Apr 20, 2022
| @@ -83,7 +84,7 @@ module.exports = { | |||
| "import/prefer-default-export": "off", | |||
| // 테스트 코드에 있는 dependencies를 dev로 옮기라고 경고 뜨는 이슈를 해결하기 위함 | |||
| // https://github.com/banksalad/styleguide/pull/35#discussion_r603753937 | |||
| "import/no-extraneous-dependencies": ["error", {"devDependencies": ["/**/*.ts?(x)"]}], | |||
| "import/no-extraneous-dependencies": ["error", { "devDependencies": ["/**/*.ts?(x)"] }], | |||
doong-jo
commented
Apr 20, 2022
| @@ -17,7 +17,7 @@ | |||
| "eslint-plugin-import": "2.22.1", | |||
| "eslint-plugin-jsx-a11y": "6.4.1", | |||
| "eslint-plugin-prettier": "3.3.1", | |||
| "eslint-plugin-react": "7.23.1", | |||
| "eslint-plugin-react": "7.29.4", | |||
There was a problem hiding this comment.
jsx-eslint/eslint-plugin-react#3248
관련 rule에 대한 개선사항이 해당 버전에 fix 되었음
grap3fruit
approved these changes
Apr 22, 2022
p-iknow
approved these changes
Apr 22, 2022
winterjung
approved these changes
Apr 25, 2022
당장 다 팔로업하기 보다는 함께 공통 eslint를 쓰게 되는 시점(monorepo)에 자연스레 챙겨지길 기대합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.