fix: mutate containers with a startup probe #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutate-probes annotation didn't mutate ENV passed to a startup probe add test for Liveness, Readiness and Startup probe separately Signed-off-by: Kamil Swoboda <kswoboda@getresponse.com>
Kaswob
force-pushed
the
add-startup-probe-mutate
branch
from
bc313d0
to
eb470cd
Compare
csatib02
approved these changes
May 16, 2024
There was a problem hiding this comment.
LGTM!
I will add your fix to our new webhook, which is under development: https://github.com/bank-vaults/secrets-webhook
csatib02
added
kind/enhancement
ramizpolic
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mutate-probes annotation didn't mutate ENV passed to a startup probe
added test for Liveness, Readiness and Startup probe separately
I've come up with an issue when trying to use vault-secrets-webhook with a bitnami/redis helm chart. Startup probes were failing due to the probes not being mutated. I've split the tests just to use test every type of probe mutation separately.