cli: remove viper StringToString pflag workaround #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
force-pushed
the
cli-remove-viper-workaround
branch
from
004e7b2
to
c3a7672
Compare
alexandear
force-pushed
the
cli-remove-viper-workaround
branch
from
c3a7672
to
89e26dc
Compare
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
alexandear
force-pushed
the
cli-remove-viper-workaround
branch
from
89e26dc
to
339a3b8
Compare
akijakya
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes viper's pflag
StringToStringworkaround as spf13/viper#608 is already fixed in 1.7.0.