Attempt to fix unrecognized input header error #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the threads listed below, this should resolve the issue, which is related to building an image with the interactive terminal flag (-t) but then running it without the flag. moby/moby#4882 moby/moby#4857 moby/moby#5327 Change-Type: patch
floion
approved these changes
Jun 7, 2017
|
lgtm |
|
Where is this interactive mode specified? What I mean where did you see that build uses interactive mode? @brownjohnf @floion |
|
I'm assuming that somewhere in the inheritance chain an image was built with interactive mode. Read those threads for more info, but this is just my best guess, at this point. |
|
Er, rather, allocating a pseudo-tty. I don't think the -i flag is strictly necessary, but i usually use them together. It's also possible that s3cmd just misbehaves when it's run without a tty or something. |
|
As far as I know we don't build images with interactive mode. I don't even know how that is possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the threads listed below, this should resolve the issue, which
is related to building an image with the interactive terminal flag (-t)
but then running it without the flag.
moby/moby#4882
moby/moby#4857
moby/moby#5327
Change-Type: patch