Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove this.skip usage as a faster workaround to afterEach skipping #940

Merged
1 commit merged into from Jul 7, 2020
Merged

Remove this.skip usage as a faster workaround to afterEach skipping #940

1 commit merged into from Jul 7, 2020

Conversation

Page-
Copy link
Contributor

@Page- Page- commented Jul 7, 2020

See: mochajs/mocha#3740

Change-type: patch

Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch

Contributor checklist
  • Includes tests
  • Includes typings
  • Includes updated documentation
  • Includes updated build output

@Page- Page- requested a review from a team as a code owner July 7, 2020 12:37
thgreasi
thgreasi approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@thgreasi thgreasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I remember suggesting the it.skip approach than the this.skip when I joined, so I'm pretty happy seeing this in a PR 👍

@thgreasi
Copy link
Member

thgreasi commented Jul 7, 2020

I see VB complaining about seeing a See label that's not on the end footer.

@ghost ghost merged commit f3f0d71 into master Jul 7, 2020
@ghost ghost deleted the faster-workaround branch July 7, 2020 14:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thgreasi thgreasi thgreasi approved these changes

@sradevski sradevski sradevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Page- @thgreasi @sradevski