Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qs parse on loadRulesFromUrl #1313

Merged
1 commit merged into from Jun 30, 2021
Merged

Fix qs parse on loadRulesFromUrl #1313

1 commit merged into from Jun 30, 2021

Conversation

JSReds
Copy link
Contributor

@JSReds JSReds commented Jun 30, 2021

Fix qs parse on loadRulesFromUrl

See: https://www.flowdock.com/app/rulemotion/resin-frontend/threads/EEoA4xg5GNkg4cHe9b1qx7tlGyN
Change-type: patch
Signed-off-by: Andrea Rosci andrear@balena.io

qs does not need the replace anymore (see: ljharb/qs#213) this was causing an infinite loop since this was changing everytime the url.


Contributor checklist
  • I have regenerated screenshots for any affected components with npm run generate-screenshots
  • I have regenerated jest snapshots for any affected components with npm run jest -- -u
Reviewer Guidelines
  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Fix qs parse on loadRulesFromUrl

Change-type: patch
Signed-off-by: Andrea Rosci <andrear@balena.io>
@JSReds JSReds requested a review from LucianBuzzo as a code owner June 30, 2021 14:53
@JSReds JSReds self-assigned this Jun 30, 2021
@JSReds
Copy link
Contributor Author

JSReds commented Jun 30, 2021

@balena-ci I self-certify!

@ghost ghost merged commit bb6b735 into master Jun 30, 2021
@ghost ghost deleted the fix-load-rules-from-url branch June 30, 2021 15:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant