Convert balstack to a render function component #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchickenburger
changed the title
evgenyboxer
reviewed
Jan 18, 2022
| if (Array.isArray(styledNestedChildren)) { | ||
| // and those children can be nullish too | ||
| const nonNullishChildren = styledNestedChildren.filter( | ||
| nestedChild => nestedChild !== undefined || nestedChild !== null |
There was a problem hiding this comment.
I assume you wanted nestedChild !== undefined && nestedChild !== null right?
Suggested change
| nestedChild => nestedChild !== undefined || nestedChild !== null | |
| nestedChild => nestedChild != null |
mrchickenburger
force-pushed
the
Convert-BalStack-To-RenderFunc
branch
from
708c8b2
to
576de39
Compare
|
Prerequisite to this being merged is merge of #1322 |
timjrobinson
approved these changes
Jan 20, 2022
| @@ -0,0 +1,83 @@ | |||
| import { render } from '@testing-library/vue'; | |||
There was a problem hiding this comment.
This looks nice! Glad we have something to do UI tests!
garethfuller
approved these changes
Jan 20, 2022
Comment on lines
+77
to
+80
| expect(getByText('First')).toHaveClass('mb-4 border-b'); | ||
| expect(getByText('Second')).toHaveClass('mb-4 border-b'); | ||
| // last el shouldn't have a spacing class | ||
| expect(getByText('Third')).not.toHaveClass('mb-4 border-b'); |
There was a problem hiding this comment.
These tests are great! Just a minor thing here, is there any advantage to maybe using the divide class and flexgrid rather than margins and flexbox?
There was a problem hiding this comment.
I'll look into it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1322 Must be merged first.
There were a few issues with out existing stack component. Given the fact that it relied on computed variable changes to re-render was a big one. It meant that it was not dynamic to changes in slots as well as having difficulty with binding v-model.
The
isDynamicprop has been made redundant as a result. So should be a bit easier to understand its APIType of change
How should this be tested?
The change is pretty visual. Just test that the app styles haven't been broken in pool creation and other areas that BalStack is used.
Visual context
Non-providable.
Checklist:
masterif hotfix,developif not