Add instructions for 'out-of-the-box' TypeScript support #412
Conversation
Cypress v4.4.0 supports TypeScript without additional preprocessors (cypress-io/cypress#1859). These are the instructions for setting that up with the Cucumber preprocessor.
|
wow, impressive debugging :) Let's wait and see what the cypress guys say. Thanks! |
|
The fix was accepted and made it into @cypress/browserify-preprocessor@v3.0.1. I guess that means the current instructions should work as soon as Cypress itself (and possibly this package) depends on that version. Looking back at the instructions, I guess it's also necessary to explicitly depend on the @cypress/browserify-preprocessor as well. It still helps that it's not necessary to introduce an additional dependency, but I don't think you can import transient dependencies either. That makes this slightly less useful than I had hoped :) Even though this preprocessor itself also depends on the browserify-preprocessor, I don't think it makes sense to add functionality to expose the TypeScript functionality through that relation. Especially since it looks like there's a migration in progress for the default preprocessor to Webpack. Just let me know if you want me to add a note to the instructions about depending on @cypress/browserify-preprocessor explicitly. |
…nction transforms The preprocessor provided by this package takes the form of a function, which isn't supported by older versions of the browserify preprocessor. The most recent versions are also necessary to support out-of-the-box TypeScript. References #412.
|
It looks like updating the dependency on @cypress/browserify-preprocessor in this package is actually sufficient to make this work. That does remove support for Node v8, I'm not sure if that's an issue. I guess it isn't as I don't think that version is officially supported anymore. But apart from that, I think this should be good to merge That is if the tests were passing. I'm not sure what's going in CI, locally these tests fail, and from what I can see this doesn't happen in anything that I touched. |
|
Circle runs on node 8, changing circle.yml here:
|
The updated dependency on @cypress/browserify-preprocessor introduced in 5f73e4d no longer supports Node.js v8. References #412.
|
Ok, looks like something is actually wrong with the dependency: |
|
What's interesting, I thought I saw this error before and I thought updating nodejs helped, now I see that this seems to be the solution: not sure yet why it didn't help in our case |
|
I'm already looking into it a bit as well. This issue had a similar error message and it looks like it's caused by an outdated The dependencies that depend on |
|
After an upgrade to Cypress v3.8.3 all tests pass as expected, should I push a commit that includes that upgrade? Or would you like to introduce these types of upgrades separately? This is growing a bit out-of-proportion for a documentation update 😄 |
|
haha, you are right, it's getting a bit out of the original scope, but not a big deal, please do push here, it's ok :) just make sure you add a proper commit message and I will rebase instead of squashing |
An outdated transient dependency (`fs-extra`) is causing syntax/parsing issues on Node v12. Upgrading the Cypress dependency includes an update to this transient dependency allowing Cypress to run on more recent Node versions. References #412.
|
Looks like it's all good now :) |
…nction transforms The preprocessor provided by this package takes the form of a function, which isn't supported by older versions of the browserify preprocessor. The most recent versions are also necessary to support out-of-the-box TypeScript. References #412.
|
Thanks @lgandecki! |
|
🎉 This PR is included in version 2.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Cypress v4.4.0 supports TypeScript without additional preprocessors (cypress-io/cypress#1859).
These are the instructions for setting that up with the Cucumber preprocessor. Which, granted, are very similar to the tsify solution but require less additional dependencies.
I'm submitting this for consideration, but have to make the note that this is blocked by cypress-io/cypress-browserify-preprocessor#56, so merging will probably have to wait until that issue is resolved.