Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(renovate): refactor config file #179

Merged
merged 2 commits into from
May 28, 2024

Conversation

MindTooth
Copy link
Contributor

I noticed the config was old and could need a update:

$ renovate-config-validator renovate.json5

 INFO: Validating renovate.json5
 WARN: Config migration necessary
       "oldConfig": {
         "labels": ["dependencies"],
         "extends": ["config:base", ":disableDependencyDashboard", ":gitSignOff"],
         "ignoreDeps": ["mkdocs-material"],
         "packageRules": [{"matchLanguages": ["python"], "rangeStrategy": "widen"}]
       },
       "newConfig": {
         "labels": ["dependencies"],
         "extends": [
           "config:recommended",
           ":disableDependencyDashboard",
           ":gitSignOff"
         ],
         "ignoreDeps": ["mkdocs-material"],
         "packageRules": [{"matchCategories": ["python"], "rangeStrategy": "widen"}]
       }
 INFO: Config validated successfully

  • Changed to using plain .json ending
  • Added schema notation on top
  • Converted to extend
  • Renamed config:base to config:recommended

Question? One question, now that we are on the latest mkdocs-material, should we then remove the ignore and rather split on major/minor so that updates will still be added? Or we can limit updates within the same x.y.


With the changes:

$ renovate-config-validator .github/renovate.json

 INFO: Validating .github/renovate.json
 INFO: Config validated successfully

@MindTooth
Copy link
Contributor Author

@johnphilip283 thoughts?

@johnphilip283
Copy link
Contributor

Hey there @MindTooth! Thank you for the PR. We'd like to be on the safer side with mkdocs-material upgrades, so I believe limiting updates within the same x.y would be a nice way to do this. Otherwise, the rest of the changes LGTM!

@MindTooth
Copy link
Contributor Author

I've updated the config to use allowedVersions to limit the range.

Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 17, 2024
@MindTooth MindTooth marked this pull request as ready for review April 17, 2024 01:30
@github-actions github-actions bot removed the stale label Apr 18, 2024
Copy link

github-actions bot commented May 2, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 2, 2024
@MindTooth
Copy link
Contributor Author

@johnphilip283 need anything more from me? 😄

@github-actions github-actions bot removed the stale label May 3, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 17, 2024
@MindTooth
Copy link
Contributor Author

Feel like I'm in a whack-a-mole game with the Stale bot. 🤣

whack-a-mole gif

@github-actions github-actions bot removed the stale label May 20, 2024
Copy link
Contributor

@alexlorenzi alexlorenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MindTooth - Thanks for the contribution. Appreciate your input

@alexlorenzi alexlorenzi merged commit cd2f993 into backstage:main May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants