Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the BehaviorSubject init into the constructor #8132

Merged
merged 1 commit into from Nov 18, 2021

Conversation

freben
Copy link
Member

@freben freben commented Nov 18, 2021

May partially address #6039

Thanks to @DanielTibbing for mentioning this

@freben freben requested a review from a team as a code owner November 18, 2021 10:00
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2021

🦋 Changeset detected

Latest commit: 475edb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@backstage/core-app-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
@freben freben force-pushed the freben/behavior-init-constructor branch from 1623959 to 475edb5 Compare November 18, 2021 10:27
@freben freben merged commit 70e4b22 into master Nov 18, 2021
@freben freben deleted the freben/behavior-init-constructor branch November 18, 2021 11:46
This was referenced Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants