Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fs-extra in scaffolder-backend #6457

Merged
merged 2 commits into from Jul 13, 2021

Conversation

jrusso1020
Copy link
Contributor

@jrusso1020 jrusso1020 commented Jul 13, 2021

Hey, I just made a Pull Request!

Update fs-extra to 10.0.0 to better handle broken symbolic links.
The only breaking changes in the major version upgrade should be
this and the requirement of node v12 or higher which backstage
also requires.

fixes #6456

Signed-off-by: jrusso1020 jrusso@brex.com

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Update fs-extra to 10.0.0 to better handle broken symbolic links.
The only breaking changes in the major version upgrade should be
this and the requirement of node v12 or higher which backstage
also requires.

fixes backstage#6456

Signed-off-by: jrusso1020 <jrusso@brex.com>
@jrusso1020 jrusso1020 requested a review from a team as a code owner July 13, 2021 16:40
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2021

🦋 Changeset detected

Latest commit: afd9c6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@backstage/plugin-scaffolder-backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjdlambert
Copy link
Member

Hmmm - really don't want to do this as this was rolled back because of #6416

Can you try and do yarn workspace @backstate/plugin-catalog add fetch with this change applied and see if it works?

@benjdlambert
Copy link
Member

Knew it was only a matter of time before something caught us out like this. The latest version does depend on 10.x that's published to npm FYI.

@benjdlambert
Copy link
Member

Just tried it, looks like it works with this so happy for this to go through.

Signed-off-by: blam <ben@blam.sh>
@benjdlambert benjdlambert merged commit 3c359a5 into backstage:master Jul 13, 2021
@jrusso1020 jrusso1020 deleted the jrusso/update-fs-extra branch July 13, 2021 18:30
@jrusso1020
Copy link
Contributor Author

Thanks @benjdlambert !

@jrusso1020
Copy link
Contributor Author

@benjdlambert I think yarn workspace @backstate/plugin-catalog add fetch works still with this change because I only updated the scaffolder plugin, whereas there is an issue in the catalog plugin? But that's just a thought

@benjdlambert
Copy link
Member

Hmm not sure. Does it work if you change the target to be the scaffolder backend? I think it's more to do with nested dependencies and yarn getting confused with hoisting or something. Not really sure, really unintuitive error message and a real pain in the ass to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Symbolic Links and fs-extra
2 participants