explicit types and remove cypress resolution override #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly list types used by each package. Without this anything inside
@types
dirs are included.Each plugin can override the types used in their
tsconfig.json
, but tbh I don't know how that will affect the package and availability of types when importing the plugin in an app later.I'm imagining this could increase build speed, but not seeing any big difference, at most a few % if anything.
The main reason for making this change was so that we can get rid of the version override of cypress, since the reason we had to do that was clashing types between jest and mocha. Now that we have to include types explicitly that's no longer an issue.