Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump cross-fetch from 3.0.6 to 3.1.3 #5175

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 30, 2021

Bumps cross-fetch from 3.0.6 to 3.1.2.

Release notes

Sourced from cross-fetch's releases.

v3.1.2

馃悶 added missing Headers interface augmentation from lib.dom.iterable.d.ts (#97)

v3.1.1

馃悶 fixed missing fetch api types from constructor signatures #96 (thanks @鈥媕stewmon)

v3.1.0

鈿★笍 improved TypeScript support with own fetch API type definitions (thanks @鈥媕stewmon) 鈿★笍 set fetch.ponyfill to true when custom ponyfill implementation is used. 馃挕 set the same fetch API test suite to run against node-fetch, whatwg-fetch and native fetch.

Commits
  • cd5ffe3 3.1.2
  • 44f9520 chore: installed commitzen config
  • 15de74f chore: added commitlint task
  • 58b7b11 added missing Headers interface augmentation from lib.dom.iterable.d.ts (#97)
  • a08ed30 changed Release action to be triggered on tag push.
  • 633fa8c 3.1.1
  • 9f02de3 added typecheck task.
  • 237ef8b added missing fetch api types from constructor signatures (#96)
  • 830d5c2 updated typescript example.
  • 9b505e9 fixed node example.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner March 30, 2021 04:24
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 30, 2021
@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2021

鈿狅笍 No Changeset found

Latest commit: 61f9443

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benjdlambert
Copy link
Member

@dependabot rebase

Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 3.0.6 to 3.1.2.
- [Release notes](https://github.com/lquixada/cross-fetch/releases)
- [Commits](lquixada/cross-fetch@v3.0.6...v3.1.2)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/cross-fetch-3.1.2 branch from 54767b2 to 892bc7a Compare March 30, 2021 12:05
@benjdlambert
Copy link
Member

There's a new version coming to fix these typescript issues: lquixada/cross-fetch#95

@benjdlambert benjdlambert changed the title chore(deps): bump cross-fetch from 3.0.6 to 3.1.2 chore(deps): bump cross-fetch from 3.0.6 to 3.1.3 Mar 31, 2021
@benjdlambert
Copy link
Member

Still failing:

node_modules/cross-fetch/lib.fetch.d.ts:4:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: RequestInfo, RequestCache, RequestCredentials, RequestDestination, RequestMode, RequestRedirect, ReferrerPolicy, ResponseType, BodyInit, HeadersInit, EventListenerOrEventListenerObject, BufferSource, FormDataEntryValue, ReadableStreamDefaultReadResult

4 declare function fetch(input: RequestInfo, init?: RequestInit): Promise<Response>;
  ~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:25:1
    25 interface Account {
       ~~~~~~~~~
    Conflicts are in this file.

node_modules/typescript/lib/lib.dom.d.ts:25:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: RequestInfo, RequestCache, RequestCredentials, RequestDestination, RequestMode, RequestRedirect, ReferrerPolicy, ResponseType, BodyInit, HeadersInit, EventListenerOrEventListenerObject, BufferSource, FormDataEntryValue, ReadableStreamDefaultReadResult

25 interface Account {
   ~~~~~~~~~

  node_modules/cross-fetch/lib.fetch.d.ts:4:1
    4 declare function fetch(input: RequestInfo, init?: RequestInit): Promise<Response>;
      ~~~~~~~
    Conflicts are in this file.


Found 2 errors.

@freben
Copy link
Member

freben commented Apr 20, 2021

let's see what the next bump brings instead, no rush

@freben freben closed this Apr 20, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 20, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/cross-fetch-3.1.2 branch April 20, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants