Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Stepper): adds custom error list for the top of the form #21878

Conversation

mattprinold
Copy link
Contributor

Hey, I just made a Pull Request!

Adds a custom error list component for the stepper form. This shows at the top of the form and captures both internal and input errors in the form.

fixes #21476

Screenshot 2023-12-15 at 10 11 32

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Matthew Prinold <matthewprinold@gmail.com>
Signed-off-by: Matthew Prinold <matthewprinold@gmail.com>
@mattprinold mattprinold requested review from a team as code owners December 15, 2023 10:12
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label Dec 15, 2023
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder-react plugins/scaffolder-react patch v1.6.2-next.3

Signed-off-by: Matthew Prinold <matthewprinold@gmail.com>
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Uffizzi Ephemeral Environment - Virtual Cluster

Your cluster pr-21878 was successfully created. Learn more about Uffizzi virtual clusters
To connect to this cluster, follow these steps:

  1. Download and install the Uffizzi CLI from https://docs.uffizzi.com/install
  2. Login to Uffizzi, then select the backstage account and project:
uffizzi login
Select an account: 
  ‣ backstage
    jdoe

Select a project or create a new project: 
  ‣ backstage-6783521
  1. Update your kubeconfig: uffizzi cluster update-kubeconfig pr-21878 --kubeconfig=[PATH_TO_KUBECONFIG]
    After updating your kubeconfig, you can manage your cluster with kubectl, kustomize, helm, and other tools that use kubeconfig files: kubectl get namespace --kubeconfig [PATH_TO_KUBECONFIG]

Access the backstage endpoint at https://backstage-default-pr-21878-c2479.uclusters.app.uffizzi.com

@mattprinold
Copy link
Contributor Author

@benjdlambert this keeps failing on the E2E tests though i cant figure out why, could i get some help on this please?

@benjdlambert
Copy link
Member

@NeuralEvolution looks like these are failing because of an upstream dependency which has been broken for a few weeks now. Hopefully should be getting solved soon 🤞

frenic/csstype#189
emotion-js/emotion#3141

Will get around to reviewing this today 🎉

Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! this looks good! 🎉

@mattprinold
Copy link
Contributor Author

@benjdlambert Thanks, i assume we are waiting for the fix for the e2e tests to merged before we can merge this?

@benjdlambert
Copy link
Member

There's a mainline release going out today, but will look at shipping this after that later on Today, and then it will be in the -next release next week :)

@benjdlambert benjdlambert merged commit 9667fc0 into backstage:master Dec 19, 2023
26 of 28 checks passed
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.22.0 release, scheduled for Tue, 16 Jan 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Regex pattern not working in software template after 1.20 update
2 participants