-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Stepper): adds custom error list for the top of the form #21878
feat(Stepper): adds custom error list for the top of the form #21878
Conversation
Signed-off-by: Matthew Prinold <matthewprinold@gmail.com>
Signed-off-by: Matthew Prinold <matthewprinold@gmail.com>
Changed Packages
|
Signed-off-by: Matthew Prinold <matthewprinold@gmail.com>
Uffizzi Ephemeral Environment - Virtual ClusterYour cluster
Access the |
@benjdlambert this keeps failing on the E2E tests though i cant figure out why, could i get some help on this please? |
@NeuralEvolution looks like these are failing because of an upstream dependency which has been broken for a few weeks now. Hopefully should be getting solved soon 🤞 frenic/csstype#189 Will get around to reviewing this today 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! this looks good! 🎉
@benjdlambert Thanks, i assume we are waiting for the fix for the e2e tests to merged before we can merge this? |
There's a mainline release going out today, but will look at shipping this after that later on Today, and then it will be in the |
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Hey, I just made a Pull Request!
Adds a custom error list component for the stepper form. This shows at the top of the form and captures both internal and input errors in the form.
fixes #21476
✔️ Checklist
Signed-off-by
line in the message. (more info)