graphql-voyager: bump dep to 2.0 + add dev setup #19364
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
Awesome, looks good. I guess we can close my PR then right? |
|
Also CC @adamdmharvey, because #19255 😅 I'll spend a bit of time digging into the CSS type issues, but don't wanna get too distracted x) |
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Uffizzi Ephemeral Environment
|
| "csstype@npm:^3.0.2, csstype@npm:^3.0.6, csstype@npm:^3.1.1, csstype@npm:^3.1.2": | ||
| version: 3.1.2 | ||
| resolution: "csstype@npm:3.1.2" | ||
| checksum: e1a52e6c25c1314d6beef5168da704ab29c5186b877c07d822bd0806717d9a265e8493a2e35ca7e68d0f5d472d43fac1cdce70fd79fd0853dff81f3028d857b5 |
There was a problem hiding this comment.
Heads-up that I ran into a similar problem here a while back, where csstype brought in a breaking change in a patch.
| declare module '@material-ui/core/styles/createTypography' { | ||
| interface Typography { | ||
| fontWeightLight: CSSProperties['fontWeight']; | ||
| fontWeightRegular: CSSProperties['fontWeight']; | ||
| fontWeightMedium: CSSProperties['fontWeight']; | ||
| fontWeightBold: CSSProperties['fontWeight']; | ||
| } | ||
| } |
There was a problem hiding this comment.
interesting. I'm not sure it's v4-specific, but rather the combination of v4 & v5 I would assume. Would be happy with this work around, if it fixes csstypes issue for now!
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
| @@ -35,7 +35,7 @@ | |||
| "@material-ui/core": "^4.12.2", | |||
| "@material-ui/icons": "^4.9.1", | |||
| "@material-ui/lab": "4.0.0-alpha.61", | |||
| "graphql-voyager": "^1.0.0-rc.31", | |||
| "graphql-voyager": "^2.0.0", | |||
There was a problem hiding this comment.
FYI:
graphql-voyager v2.0.0 upgraded from (previously at RC31) material-ui v4 to v5
"@mui/icons-material": "5.11.0",
"@mui/lab": "5.0.0-alpha.114",
"@mui/material": "5.11.2",
PS: This PR could resolve #19327 and #19326.
The RC31 was dependent on "@material-ui/core": ^3.9.3 -> recompose: 0.28.0 - 0.30.0 -> fbjs: ^0.8.1 -> isomorphic-fetch: ^2.1.1 -> node-fetch: ^1.0.1
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Hey, I just made a Pull Request!
This bump breaks part of the styling of the plugin, but we can't keep it on the 1.0 RC as it brings in some old dependencies like MUI 3. Will leave it to additional contributions to fix the style issues. The plugin is still somewhat functional.
CC @MitchWijt in case you want to have a look
✔️ Checklist
Signed-off-byline in the message. (more info)