Issue with Symbolic Links and fs-extra #6456
Labels
bug
Something isn't working
Comments
jrusso1020
added a commit
to jrusso1020/backstage
that referenced
this issue
Jul 13, 2021
Update fs-extra to 10.0.0 to better handle broken symbolic links. The only breaking changes in the major version upgrade should be this and the requirement of node v12 or higher which backstage also requires. fixes backstage#6456 Signed-off-by: jrusso1020 <jrusso@brex.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Broken Symbolic links should be handled by fs-extra similarly to how it's handled by cp -r. The scaffolder should be able to handle these broken symbolic links
For context we have a monorepo, so we keep a local copy of the monorepo stored on our backstage backend server which we periodically fetch changes for. We take our templates and copy them into a specific working directory in the monorepo git repository and then commit and push those changes to the remote.
Current Behavior
When symbolic links are broken, it breaks the scaffolder with an error like
This issue is also outlined here jprichardson/node-fs-extra#638 and fixed in this PR jprichardson/node-fs-extra#779 which was released as part of the 10.0.0 release https://github.com/jprichardson/node-fs-extra/releases/tag/10.0.0 of fs-extra
Possible Solution
Update fs-extra in the scaffolder-backend to 10.0.0. Testing this change on our version of backstage and happy to also open a PR for the open source project
Steps to Reproduce
The issue from fs-extra has an example of how to reproduce. For us it's been sporadic, some time the symbolic links are okay and other times they are broken when scaffolding.
Context
This has caused our scaffolder to randomly break
Your Environment
The text was updated successfully, but these errors were encountered: