Skip to content

Commit

Permalink
fix(cli): adds missing dependencies
Browse files Browse the repository at this point in the history
fix(cli): adds missing dependencies

Addresses:
- !24674

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
  • Loading branch information
jkilzi committed May 9, 2024
1 parent 7183fe7 commit 634b40f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/eighty-donuts-sparkle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@backstage/cli': patch
---

Fixes an issue where frontend plugins didn't have react, react-dom and react-router-dom dependencies populated in the final package.json
5 changes: 4 additions & 1 deletion packages/cli/templates/default-plugin/package.json.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@
"@testing-library/jest-dom": "{{versionQuery '@testing-library/jest-dom' '6.0.0'}}",
"@testing-library/react": "{{versionQuery '@testing-library/react' '14.0.0'}}",
"@testing-library/user-event": "{{versionQuery '@testing-library/user-event' '14.0.0'}}",
"msw": "{{versionQuery 'msw' '1.0.0'}}"
"msw": "{{versionQuery 'msw' '1.0.0'}}",
"react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}",
"react-dom": "{{versionQuery 'react-dom' '^16.13.1 || ^17.0.0 || ^18.0.0'}}",
"react-router-dom": "{{versionQuery 'react-router-dom' '6.0.0-beta.0 || ^6.3.0'}}"
},
"files": [
"dist"
Expand Down

0 comments on commit 634b40f

Please sign in to comment.