Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreExtensions docs #2773

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 26, 2023

Add ignoreExtensions docs introduced in Babel 7.21.4.

Companion PR of babel/babel#14955

This PR depends on #2772, I will rebase after it is merged.

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for babel-next ready!

Name Link
🔨 Latest commit 52a5638
🔍 Latest deploy log https://app.netlify.com/sites/babel-next/deploys/655fc2be164a7300070c5b49
😎 Deploy Preview https://deploy-preview-2773--babel-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for babel ready!

Name Link
🔨 Latest commit 52a5638
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/655fc2be0e75fc0008709956
😎 Deploy Preview https://deploy-preview-2773--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JLHwung JLHwung force-pushed the add-ignore-extensions-docs branch from c59bb65 to 7babe42 Compare May 5, 2023 02:49
@JLHwung JLHwung added the docs label May 5, 2023
@nicolo-ribaudo nicolo-ribaudo added this to the Babel 8.0 milestone Jun 16, 2023
@@ -91,4 +91,17 @@ class A {
}
```

:::babel8

### `ignoreExtensions`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we support this option in Babel 7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Looking back that PR should have been marked as New Features so we wouldn't have shipped it in a patch release.

@nicolo-ribaudo nicolo-ribaudo merged commit 6501899 into babel:main Nov 24, 2023
4 checks passed
@JLHwung JLHwung deleted the add-ignore-extensions-docs branch November 24, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants