This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Breaking: Deprecate built-in rules #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
reviewed
Nov 17, 2016
| "babel/object-curly-spacing": 1, | ||
| "babel/object-shorthand": 1, | ||
| "babel/arrow-parens": 1, | ||
| "babel/no-await-in-loop": 1, | ||
| "babel/flow-object-type": 1, |
There was a problem hiding this comment.
This can be removed as well. It's now https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-object-type-delimiter.
|
Didn't write a test so testing locally and it's not doing anything so probably copy pasted wrong nvm it doesn't show the warning when using --format? not sure why |
This was referenced Nov 17, 2016
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
* Deprecate built-in rules * fix update to babel-eslint 7 with awaitexpression * deprecate flow-object-type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
deleted all the tests
replaced the code with the deprecation code mentioned https://github.com/yannickcr/eslint-plugin-react/blob/e1697996ff494bf584057418e2974ece7f3d99d8/lib/rules/wrap-multilines.js#L45-L53
https://github.com/hzoo/eslint-plugin-babel/tree/deprecate-rules#deprecated