Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Deprecate upstreamed rules #106

Closed
taion opened this issue Oct 24, 2016 · 3 comments
Closed

Deprecate upstreamed rules #106

taion opened this issue Oct 24, 2016 · 3 comments

Comments

@taion
Copy link

taion commented Oct 24, 2016

The following rules have had their effects added upstream:

  • babel/generator-star-spacing: ESLint now supports async/await, and the upstream rule works fine
  • babel/object-shorthand: This works upstream now
  • babel/arrow-parens: async support works upstream; the only difference now is this handles Flow annotations and doesn't tell me that I have unnecessary parens when using (foo: mixed) => foo, and as such should probably go in eslint-plugin-flowtype
  • babel/func-params-comma-dangle: Supported in comma-dangle as of ESLint v3.8.0

It would be ideal if we could warn when these rules are enabled, and look to removing them in the future.

There's currently no fully built-in way to warn on deprecated rules (see eslint/eslint#7443), but the pattern in eslint-plugin-react looks pretty good: https://github.com/yannickcr/eslint-plugin-react/blob/e1697996ff494bf584057418e2974ece7f3d99d8/lib/rules/wrap-multilines.js#L45-L53.

@taion
Copy link
Author

taion commented Oct 24, 2016

Well, okay, that's is if you want to be really fastidious.

If it were me, I'd bump the peer dependency to ESLint v3.8.0, drop support for Node <4, delete the old rules, and do a major version bump.

@taion
Copy link
Author

taion commented Oct 24, 2016

@danharper pointed out that the arrow-parens rule here will be fully deprecated once eslint/eslint#7436 lands.

@taion
Copy link
Author

taion commented Oct 24, 2016

babel/array-bracket-spacing will be on that list as well, if the ESLint maintainers accept eslint/eslint#7445.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant