This repository has been archived by the owner on May 19, 2018. It is now read-only.
WIP: Better error messaging for incorrect use of 'await' #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
commented
Oct 22, 2016
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "throws": "Unexpected token, expected ; (1:6)" | |||
There was a problem hiding this comment.
I'm still unsure how we can safely insert a better error message for this case, given that this needs to be allowed: https://github.com/babel/babylon/blob/master/test/fixtures/esprima/es2015-identifier/valid_await/actual.js
If it must be surrounded by parens, we can definitely make that warning. Otherwise, not sure how to do that one. Any ideas?
|
Whoops, was just made aware of #125. Going to go ahead and close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113
This PR does two things:
awaitis not used in anasyncfunctionasyncas anIdentifierwhen source type is module (as outlined in Fix reserved keywords #134). See http://www.ecma-international.org/ecma-262/6.0/#sec-future-reserved-words for relevant part of the spec.Marking this as WIP because I haven't been able to figure out how to warn for
awaitoutside of functions safely. Please see comment below.