Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use lookahead when parsing imports in declare module in flow #9987

Merged
merged 1 commit into from May 16, 2019
Merged

Do not use lookahead when parsing imports in declare module in flow #9987

merged 1 commit into from May 16, 2019

Conversation

danez
Copy link
Member

@danez danez commented May 16, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Just noticed there is another obvious case that can be change and as the other PR already had a review I did not want to add it there.

@danez danez added area: perf PR: Polish 💅 A type of pull request used for our changelog categories area: flow pkg: parser labels May 16, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10800/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10800/

@danez danez merged commit 5661de5 into babel:master May 16, 2019
@danez danez deleted the flow-no-lookahead-2 branch May 16, 2019 09:31
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow area: perf outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants