Fix parsing typescript bodiless methods with the estree plugin also enabled #9890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why CI is failing. Seems to be something related to preset-env. Looks like a few other PRs are also failing. |
|
Yeah, CI failure is unrelated. |
nicolo-ribaudo
approved these changes
Apr 22, 2019
nicolo-ribaudo
added
area: typescript
pkg: parser
PR: Bug Fix 🐛
existentialism
approved these changes
Apr 23, 2019
danez
approved these changes
Apr 23, 2019
This was referenced Aug 17, 2019
This was referenced Sep 17, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes parsing of typescript bodiless methods when the estree plugin is also enabled. For context, I am adding TS support to react-docgen, which uses babel-parser with recast and therefore requires estree. reactjs/react-docgen#348
Currently, when both the typescript plugin and estree are enabled, code like the following causes a parsing error.
The problem was that the type was overridden prior to parsing, and the typescript plugin uses the type to determine whether a bodiless method is allowed. The PR fixes this issue by passing the original type through and only overriding it afterward.