Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in cloneNode. #9832

Merged
merged 1 commit into from Apr 8, 2019
Merged

Fix typo in cloneNode. #9832

merged 1 commit into from Apr 8, 2019

Conversation

evandervalk
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #9828
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No (Unable to run tests on Windows)
Documentation PR Link No
Any Dependency Changes? No
License MIT

Fixed a typo in the cloneNode function. Changed innerCmments to innerComments.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10673/

nicolo-ribaudo
nicolo-ribaudo approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jridgewell jridgewell merged commit 165ef29 into babel:master Apr 8, 2019
@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: types labels Apr 8, 2019
This was referenced Aug 17, 2019
Open
Closed
This was referenced Sep 17, 2019
Closed
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in babel-types cloneNode()
5 participants
@evandervalk @babel-bot @jridgewell @nicolo-ribaudo @existentialism