Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-polyfill: move global import #9815

Closed
wants to merge 1 commit into from
Closed

babel-polyfill: move global import #9815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/babel-polyfill/src/index.js
View file
Open in desktop
@@ -1,7 +1,5 @@
import "./noConflict";

import global from "core-js/library/fn/global";

if (global._babelPolyfill && typeof console !== "undefined" && console.warn) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't global only needed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! I had the global object proposal in mind, but it's not even name that way anymore. Let's close this PR.

console.warn(
"@babel/polyfill is loaded more than once on this page. This is probably not desirable/intended " +
Expand Down
3 changes: 3 additions & 0 deletions packages/babel-polyfill/src/noConflict.js
View file
Open in desktop
Expand Up @@ -18,3 +18,6 @@ import "core-js/fn/promise/finally";
import "core-js/web";

import "regenerator-runtime/runtime";

// eslint-disable-next-line no-unused-vars
import global from "core-js/library/fn/global";