Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't accept '\08' or '\09' in strict mode #9769

Merged
merged 1 commit into from Apr 2, 2019
Merged

Don't accept '\08' or '\09' in strict mode #9769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/babel-parser/src/tokenizer/index.js
View file
Open in desktop
Expand Up @@ -1213,7 +1213,13 @@ export default class Tokenizer extends LocationParser {
octalStr = octalStr.slice(0, -1);
octal = parseInt(octalStr, 8);
}
if (octal > 0) {
this.state.pos += octalStr.length - 1;
const next = this.input.charCodeAt(this.state.pos);
if (
octalStr !== "0" ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as the previous octal > 0, right? Or is it different in case of \00?

Copy link
Member Author

@danez danez Mar 26, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, this is doing exactly the same thing. I copied this part from acorn that's why it changed.

next === charCodes.digit8 ||
next === charCodes.digit9
) {
if (inTemplate) {
this.state.invalidTemplateEscapePosition = codePos;
return null;
Expand All @@ -1226,7 +1232,7 @@ export default class Tokenizer extends LocationParser {
this.state.octalPosition = codePos;
}
}
this.state.pos += octalStr.length - 1;

return String.fromCharCode(octal);
}

Expand Down
3 changes: 0 additions & 3 deletions scripts/tests/test262/test262_whitelist.txt
View file
Open in desktop
Expand Up @@ -411,8 +411,6 @@ language/expressions/object/method-definition/private-name-early-error-gen-insid
language/expressions/object/method-definition/private-name-early-error-gen-inside-class.js(strict mode)
language/expressions/object/method-definition/private-name-early-error-method-inside-class.js(default)
language/expressions/object/method-definition/private-name-early-error-method-inside-class.js(strict mode)
language/expressions/template-literal/invalid-legacy-octal-escape-sequence.js(default)
language/expressions/template-literal/invalid-legacy-octal-escape-sequence.js(strict mode)
language/expressions/template-literal/unicode-escape-nls-err.js(default)
language/expressions/template-literal/unicode-escape-nls-err.js(strict mode)
language/identifiers/unicode-escape-nls-err.js(default)
Expand Down Expand Up @@ -588,7 +586,6 @@ language/literals/regexp/u-unicode-esc-non-hex.js(default)
language/literals/regexp/u-unicode-esc-non-hex.js(strict mode)
language/literals/regexp/unicode-escape-nls-err.js(default)
language/literals/regexp/unicode-escape-nls-err.js(strict mode)
language/literals/string/legacy-non-octal-escape-sequence-strict.js(strict mode)
language/literals/string/unicode-escape-nls-err-double.js(default)
language/literals/string/unicode-escape-nls-err-double.js(strict mode)
language/literals/string/unicode-escape-nls-err-single.js(default)
Expand Down