Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow coreJS Symbol to be type object #9756

Merged
merged 1 commit into from Mar 24, 2019

Conversation

conartist6
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #9755
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR Link None
Any Dependency Changes? No
License MIT

See the #9755 for a detailed description of the problem.

@babel-bot
Copy link
Collaborator

babel-bot commented Mar 23, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10584/

@nicolo-ribaudo
Copy link
Member

@zloirock Is it expected that core-js creates an object-type Symbol when polyfilling only wks?

@zloirock
Copy link
Member

zloirock commented Mar 23, 2019

@nicolo-ribaudo yes. However, I'm not sure how it's related to runtime since this helper uses Symbol directly.

@conartist6
Copy link
Contributor Author

This code appears to use Symbol directly, but it is transpiled prior to shipping such that it ends up importing Symbol from core-js.

@nicolo-ribaudo
Copy link
Member

Someone could also manually import the polyfill for Symbol.asyncIterable without importing Symbol() polyfill.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: helpers labels Mar 23, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit ff04d35 into babel:master Mar 24, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: helpers outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Object is not async iterable
4 participants